-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add more e2e tests for device request prompt #11185
test: add more e2e tests for device request prompt #11185
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
FYI: I just filed #11189 and back-linked all merged PRs so far to it, including this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + Two minor comment before we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + The Expectations needed to be update and one JS issue fixes - put suggested fixes.
Other then that once CI passes I will merge.
dd727f6
to
1c22c71
Compare
295db9d
to
24f7fc3
Compare
24f7fc3
to
d6a53b7
Compare
d6a53b7
to
fcc417c
Compare
While investigating the timeout issue I found some problems:
|
Head branch was pushed to by a user without write access
Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
cf0301f
to
f8374a7
Compare
f8374a7
to
1787c26
Compare
@thiagowfx do you have a plan for this? It looks like the feature is not testable on GitHub actions because there are no Bluetooth devices there. |
Closing this as it seems it not possible to test with GitHub Actions. |
What kind of change does this PR introduce?
Adds some more basic e2e tests for
DeviceRequestPrompt
. These tests don't involve actual bluetooth connection scenarios since those would be hard to scaffold, but these will exercise more of the code to validate basic functioning and a couple error states. These e2e tests must be run headed since the bluetooth chooser will not launch on headless chrome instances.Did you add tests for your changes?
It's all tests :)
If relevant, did you update the documentation?
Summary
Building off of #11072 and #11159, this PR adds a few more e2e tests for
DeviceRequestPrompt
that can be run headed.Does this PR introduce a breaking change?
Nope.
Other information
cc @thiagowfx
Bug: #11189