Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1413
After playing around with frames, I figured out that execution order is:
frameattached
framenavigated
window.onLoad
This means that the two steps are needed:
I added a section in
Frame
docs:Waiting for a frame to be loaded
, explaining this concept with the example from #1361.I think that we might need a better built-in solution for that, something like:
page.waitForFrameAttached(frameName)
WDYT?