feat(docs): mention puppeteer@chrome tagged releases #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Nov 12, 2018
README.md
Outdated
| npm i puppeteer-core | ||
| # or "yarn add puppeteer-core" | ||
| npm i puppeteer-core@chrome-71 | ||
| # or "yarn add puppeteer-core@chrome-71" |
There was a problem hiding this comment.
I'd keep this as, otherwise it is confusing: reader at this point has no idea what's chrome-71 and why they should install this version of pptr-core.
satanninja
approved these changes
Nov 12, 2018
README.md
Outdated
| @@ -312,6 +313,11 @@ This is not an artificial constraint: A lot of work on Puppeteer is actually tak | |||
|
|
|||
| However, oftentimes it is desirable to use Puppeteer with the official Google Chrome rather than Chromium. For this to work, you should pick the version of Puppeteer that uses the Chromium version close enough to Chrome. | |||
|
|
|||
| Since Chrome 70, the latest supported version Puppeteer is tagged on npm. To install Puppeteer for use with Chrome 71: | |||
There was a problem hiding this comment.
the latest supported version Puppeteer is tagged on npm
I am not sure, but is some word missing here?
|
close |
|
@JoelEinbinder updated this - ptal |
aslushnikov
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also add a note about them to the [For Project Maintainers] section of CONTRIBUTING.md, but I am not sure what the process actually is.