Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): mention puppeteer@chrome tagged releases #3528

Merged
merged 3 commits into from
Jan 11, 2019
Merged

feat(docs): mention puppeteer@chrome tagged releases #3528

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a45fe1e
feat(docs): mention puppeteer@chrome tagged relases
JoelEinbinder Nov 12, 2018
f879af8
Update README.md
aslushnikov Jan 11, 2019
6f4b3f4
Update README.md
aslushnikov Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,12 @@ Since version 1.7.0 we publish the [`puppeteer-core`](https://www.npmjs.com/pack
a version of Puppeteer that doesn't download Chromium by default.

```bash
npm i puppeteer-core
# or "yarn add puppeteer-core"
npm i puppeteer-core@chrome-71
# or "yarn add puppeteer-core@chrome-71"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep this as, otherwise it is confusing: reader at this point has no idea what's chrome-71 and why they should install this version of pptr-core.

```

`puppeteer-core` is intended to be a lightweight version of Puppeteer for launching an existing browser installation or for connecting to a remote one.
`puppeteer-core` is intended to be a lightweight version of Puppeteer for launching an existing browser installation or for connecting to a remote one. Be sure that the version of puppeteer-core you install is compatible with the
browser you intend to connect to.

See [puppeteer vs puppeteer-core](https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#puppeteer-vs-puppeteer-core).

Expand Down Expand Up @@ -312,6 +313,11 @@ This is not an artificial constraint: A lot of work on Puppeteer is actually tak

However, oftentimes it is desirable to use Puppeteer with the official Google Chrome rather than Chromium. For this to work, you should pick the version of Puppeteer that uses the Chromium version close enough to Chrome.

Since Chrome 70, the latest supported version Puppeteer is tagged on npm. To install Puppeteer for use with Chrome 71:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest supported version Puppeteer is tagged on npm

I am not sure, but is some word missing here?

```bash
npm install puppeteer@chrome-71
```

#### Q: Which Chromium version does Puppeteer use?

Look for `chromium_revision` in [package.json](https://github.com/GoogleChrome/puppeteer/blob/master/package.json).
Expand Down