fix(browser): Close browser targets before closing browser itself #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Dec 18, 2018
There was a problem hiding this comment.
Thanks for the PR. Solving this on puppeteer-side is racy: targets might spawn new targets with beforeunload dialogs and so on.
I've submitted a CL to fix this on the protocol-side: https://chromium-review.googlesource.com/c/chromium/src/+/1381513
|
Closing this PR in favor of upstream fix. |
|
Ah yes that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3673 by adding logic to browser.close to close the browser targets first before the browser. This seems to ignore the beforeunload dialog on the page and succesfully closes the browser.