chore: cleanup puppeteer.connect({browserURL}) #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - renames `browserUrl` into `browserURL` - cleans up some code - adds tests for error handling References puppeteer#3537
JoelEinbinder
approved these changes
Jan 14, 2019
lib/Launcher.js
Outdated
| ignoreHTTPSErrors = false, | ||
| defaultViewport = {width: 800, height: 600}, | ||
| transport, | ||
| slowMo = 0, | ||
| } = options; | ||
|
|
||
| let connectionUrl; | ||
| let connectionTransport; | ||
| assert(!!browserWSEndpoint + !!browserURL + !!transport === 1, 'Exactly one of browserWSEndpoint, browserURL or transport must be passed to puppeteer.connect'); |
There was a problem hiding this comment.
It got even fancies thanks to TSC strictness
| connectionTransport = await WebSocketTransport.create(connectionUrl); | ||
| let connection = null; | ||
| if (transport) { | ||
| connection = new Connection('', transport, slowMo); |
There was a problem hiding this comment.
Null instead of empty string?
There was a problem hiding this comment.
Must be a string per our docs and everything - I'd keep it as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
browserUrlintobrowserURLReferences #3537