Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup puppeteer.connect({browserURL}) #3766

Merged
merged 2 commits into from
Jan 14, 2019
Merged

chore: cleanup puppeteer.connect({browserURL}) #3766

merged 2 commits into from
Jan 14, 2019

Commits on Jan 14, 2019

  1. chore: cleanup puppeteer.connect({browserURL}) 

    This patch:
- renames `browserUrl` into `browserURL`
- cleans up some code
- adds tests for error handling

References puppeteer#3537
    @aslushnikov
    aslushnikov committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    c5dcfeb View commit details
    Browse the repository at this point in the history

  2. fix lint

    @aslushnikov
    aslushnikov committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    cf6e181 View commit details
    Browse the repository at this point in the history