Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(firefox): run all tests without "UnhandledPromiseRejection" error #3922

Merged
merged 1 commit into from
Feb 6, 2019
Merged

chore(firefox): run all tests without "UnhandledPromiseRejection" error #3922

merged 1 commit into from
Feb 6, 2019

Commits on Feb 6, 2019

  1. chore(firefox): run all tests without "UnhandledPromiseRejection" error 

    This aligns all Puppeteer tests so that they never throw the
"UnhandledPromiseRejection" when run with Puppeteer-Firefox.

With this patch, the `npm run funit` passes 275 of 460 Puppeteer tests.

References puppeteer#3889.
    @aslushnikov
    aslushnikov committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    0cb9f27 View commit details
    Browse the repository at this point in the history