-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): publish protocol types to npm #5174
Conversation
CONTRIBUTING.md
Outdated
@@ -252,8 +252,9 @@ Releasing to npm consists of the following phases: | |||
1. On your local machine, pull from [upstream](https://github.com/GoogleChrome/puppeteer) and make sure the last commit is the one just merged. | |||
2. Run `git status` and make sure there are no untracked files. | |||
- **WHY**: this is to avoid adding unnecessary files to the npm package. | |||
3. Run [`npx pkgfiles`](https://www.npmjs.com/package/pkgfiles) to make sure you don't publish anything unnecessary. | |||
4. Run `npm publish`. This publishes the `puppeteer` package. | |||
3. Run `yarn` to make sure the latest `lib/protocol.d.ts` is generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an easy way to do this that does not require installingyarn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work for npm install
too. It's done in an install hook.
Could replace with npm run install / yarn install
.
Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
Thanks! |
see #5168