-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(agnostification): create web
for web only code
#6524
Conversation
This change makes a `web` folder to house any code that is just for the browser and won't work in a Node environment. We have three folders now to divide code up nicely: - `node` - `web` - `common`.
f5b16cf
to
1c3a977
Compare
One thing I'd welcome opinions on: the two That said, I cannot find a nice way to avoid the duplication in the code that doesn't 1) make it far more complex, 2) lose some type safety. That's why I've left the duplication as I think it's actually best (or least worst) compared to forcing an abstraction. |
How did you arrive at |
None really beyond I think we've talked about it as |
03a4ca1
to
d4b17bd
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@jackfranklin I updated the pr - let me know if you think it's still relevant.
Do you know if that would be possible? |
Closing this for now as discussed offline with @jackfranklin |
This change makes a
web
folder to house any code that is just for thebrowser and won't work in a Node environment.
We have three folders now to divide code up nicely:
node
web
common
.