Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): fix lint in code snippets #7012

Merged

Conversation

theDavidBarton
Copy link
Contributor

Fixed and standardized object-curly-spacing, quotes and semi mistakes in the code snippets of api.md. Where neither prettier.config.js nor .eslintrc.js mentioned the rule I checked the preferred usage within the project from the examples folder.

@google-cla google-cla bot added the cla: yes label Mar 21, 2021
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we automate this?

@mathiasbynens mathiasbynens merged commit ff86081 into puppeteer:main Mar 22, 2021
@theDavidBarton
Copy link
Contributor Author

Nice! Should we automate this?

@mathiasbynens I made a proposal for this in #7014

@theDavidBarton theDavidBarton deleted the docs-api-md-fix-code-snippets branch March 22, 2021 21:38
mathiasbynens added a commit that referenced this pull request Mar 23, 2021
Issue: #7012
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
@haaami01
Copy link

Javítva és szabványosítva object-curly-spacing, quotesvalamint semihibák a api.md. Ahol sem a szabályt prettier.config.jsnem .eslintrc.jsemlítettem, sem a examplesmappából ellenőriztem a projekten belüli előnyben részesített felhasználást .

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants