chore: update prettier globs and format files #7856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
prettier-globs
branch
from
b21266b
to
b8a4e62
Compare
|
Thanks for this; All PRs are broken linter was added but the code is not properly formatted. If @johanbay @mathiasbynens approve this, we can rebase the rest of PRs 🙏 |
|
I think for js files we use prettier through eslint to avoid conflicts. Would it work without conflicts with eslint? Thanks a lot for the PR and I appreciate if you can rebase it if it's compatible with eslint. |
|
Yes, ESLint prettier passes out to the main library, and uses the same config |
nschonni
force-pushed
the
prettier-globs
branch
from
9e17bb4
to
03332b8
Compare
nschonni
force-pushed
the
prettier-globs
branch
from
03332b8
to
6ba72bc
Compare
|
@OrKoN gave it a rebase and added in a few ignores from a CI failure. Unfortunately the prettierignore doesn't merge with gitignore currently, so there is a bit of duplication |
|
Looks like there was a dangling reference to Markdownlint, so I removed that for now |
|
looks like CI is happy this time |
OrKoN
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Updated to get a clean run with prettier running across all files. Ignore some generated and test content that shouldn't be formatted
Does this PR introduce a breaking change?
Other information