chore: remove commit lint from pull requests #7957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
changed the title
OrKoN
changed the title
|
@mathiasbynens @johanbay PTAL |
johanbay
approved these changes
Feb 4, 2022
| @@ -26,7 +26,7 @@ | |||
| "commitlint": "commitlint --from=HEAD~1", | |||
| "markdownlint": "prettier --check **/README.md docs/troubleshooting.md", | |||
| "markdownlint-fix": "prettier --write **/README.md docs/troubleshooting.md", | |||
| "lint": "npm run eslint && npm run build && npm run doc && npm run commitlint && npm run markdownlint", | |||
| "lint": "npm run eslint && npm run build && npm run doc && npm run markdownlint", | |||
There was a problem hiding this comment.
We could consider making a new target ci-lint or similar that skips commitlint and leave the lint target as is? That way, devs still runs commitlint in their local workflows per default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit log is still checked post-merge. Before the merge the commit message is checked using a git hooks and conventionalcommits.org check on the PR using Github Actions.