Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove commit lint from pull requests #7957

Merged
merged 2 commits into from
Feb 4, 2022
Merged

chore: remove commit lint from pull requests #7957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7220fb4
chore: remove commit lint from pull requests
OrKoN Feb 2, 2022
7ffe757
Merge branch 'main' into chore-commitlint
OrKoN Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ jobs:
npm run ensure-correct-devtools-protocol-revision
npm run test-types-file

- name: Run commit lint
run: |
npm run commitlint
if: github.event_name != 'pull_request'

- name: Run unit tests
uses: nick-invision/retry@v2
env:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"commitlint": "commitlint --from=HEAD~1",
"markdownlint": "prettier --check **/README.md docs/troubleshooting.md",
"markdownlint-fix": "prettier --write **/README.md docs/troubleshooting.md",
"lint": "npm run eslint && npm run build && npm run doc && npm run commitlint && npm run markdownlint",
"lint": "npm run eslint && npm run build && npm run doc && npm run markdownlint",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider making a new target ci-lint or similar that skips commitlint and leave the lint target as is? That way, devs still runs commitlint in their local workflows per default.

"doc": "node utils/doclint/cli.js",
"clean-lib": "rimraf lib",
"build": "npm run tsc && npm run generate-d-ts",
Expand Down