Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node18 as docker base image #9456

Merged

Conversation

tailgo
Copy link
Contributor

@tailgo tailgo commented Dec 28, 2022

What kind of change does this PR introduce?

feature: use node-18 as docker base image.
fix: fix docker's readme wrong content.

Did you add tests for your changes?

yes.

If relevant, did you update the documentation?

fix some wrong content with docker's readme.

Summary

#9453

Does this PR introduce a breaking change?

May cause a breaking change while other user use latest tag docker image in their product.

Other information

@google-cla
Copy link

google-cla bot commented Dec 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tailgo tailgo force-pushed the feat/use-nodejs18-as-docker-base-image branch from 9b5ac42 to 235256b Compare December 28, 2022 09:50
@jrandolf-2 jrandolf-2 merged commit 86441e3 into puppeteer:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants