Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Fully genericize install command #350

Open
6 tasks
michaeltlombardi opened this issue Feb 15, 2022 · 0 comments
Open
6 tasks

Fully genericize install command #350

michaeltlombardi opened this issue Feb 15, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@michaeltlombardi
Copy link
Contributor

The install command is extremely similar in pct and prm - the primary differences are in language about the type of package being installed. If install is fully genericized, it can be imported and used in prm without maintaining near-identical code in two repositories and re-used in any other projects.

Acceptance Criteria

  • The InstallCommand struct has a new property, ProjectType which takes a string
  • The InstallCommand struct renames TemplatePkgPath to InstalledPkgPath
  • The instantiation of the install command in main passes the ProjectType as template and updates from TemplatePkgPath to InstalledPkgPath.
  • All references to template are genericized, using the ProjectType where sensible (including command help, flag names/descriptions, errors, informational messages, and comments) instead of hard-coding template
  • Variables referencing template are updated to package
  • Tests updated as necessary
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants