This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
(MAINT) Better error outputting to terminal #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
force-pushed
the
maint/main/add_better_terminal_output
branch
2 times, most recently
from
a96c71c
to
057fd84
Compare
petergmurphy
force-pushed
the
maint/main/add_better_terminal_output
branch
3 times, most recently
from
dfbbd3d
to
5f56a0e
Compare
petergmurphy
force-pushed
the
maint/main/add_better_terminal_output
branch
from
5f56a0e
to
2ade9fe
Compare
This commit changes how errors are outputted to the terminal. Previously, when a tool returned a non-success exit code and no stderr, the terminal would just output an exit code. Now, when tool returns a non-success exit code and no stderr, the stdout will be outputted to the terminal. The tool's stdout should contain what validation errors occurred. This commit also adds a change to how the code directory is presented in the outputted text. Previously, any usage of a code directory would have `/code/` prepended onto it as it was mounted to this docker directory. Now PRM will find and remove any usage of `/code/` in the output text.
petergmurphy
force-pushed
the
maint/main/add_better_terminal_output
branch
from
2ade9fe
to
41e3b20
Compare
chelnak
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how errors are outputted to the terminal.
Previously, when a tool returned a non-success exit code and no stderr,
the terminal would just output an exit code. Now, when tool returns a
non-success exit code and no stderr, the stdout will be outputted to the
terminal. The tool's stdout should contain what validation errors occurred.
Before:
5:00PM INF Validating with the metadata-json-lint tool 5:00PM ERR metadata-json-lint: Tool exited with code: 1 TOOL NAME | VALIDATION EXIT CODE ---------------------+----------------------- metadata-json-lint | 1 5:00PM ERR Validation returned 1 errorAfter: