This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
(PRE-93) Change CLI options to use dash instead of underscore #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase needed |
All CLI options in the Puppet code-base uses dash as word separator. Before this commit, catalog-preview used an underscore. This commit changes this so that both dash and underscore can be used (to retain backward compatibility). The documentation is changed to only mention the dash variants. The commit also changes boolean options so that they can be prefixed with 'no-' to negate their meaning. This will be relevant when we add boolean options that default to `true` (as the planned --diff-array-value for instance) and we want to provide a way to turn the option off.
thallgren
force-pushed
the
issue/pre-93/dash-in-cli-options
branch
from
089cb83
to
282a25b
Compare
|
The README,md needs the same update as the help.md file (They are not identical, so cannot simply be copied over, the README needs to be edited). Merging this though as it is blocking other PRs. Can do a (maint) to fix the README. |
hlindberg
added a commit
that referenced
this pull request
Mar 16, 2016
(PRE-93) Change CLI options to use dash instead of underscore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All CLI options in the Puppet code-base uses dash as word separator.
Before this commit, catalog-preview used an underscore. This commit
changes this so that both dash and underscore can be used (to retain
backward compatibility). The documentation is changed to only mention
the dash variants.
The commit also changes boolean options so that they can be prefixed
with 'no-' to negate their meaning. This will be relevant when we add
boolean options that default to
true(as the planned--diff-array-value for instance) and we want to provide a way to turn
the option off.