This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
(PRE-104) add_node_to_puppetdb spec helper #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the logic to add nodes in puppetdb in the spec_helper_integration file into its own helper method. This change will allow individual spec tests to add nodes for their discrete use cases. Specifically, this will allow for the addition of nodes that will then be deactivated without negatively impacting the database for other tests.
| add_node_to_puppetdb(test_node, 'production') | ||
| on master, puppet('node', 'deactivate', test_node) | ||
|
|
||
| it 'should skip inactive nodes by default' do |
There was a problem hiding this comment.
we're explicitly using the flag here, which i also believe is the default. is this as intended?
This commit adds a test for the `--skip-inactive-nodes` flag. It tests that an inactive node is not included by default when the flag is used. A placeholder for the negative case `--no-skip-inactive-nodes` is also included. This test is marked as pending until PRE-115 is resolved.
|
this LGTM, but let's wait until the release to merge... |
|
Tested this out and it works fine, right up to the last case which fails because of PUP-115, marked pending. +1 for merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the logic to add nodes in puppetdb in the
spec_helper_integration file into its own helper method. This
change will allow individual spec tests to add nodes for their
discrete use cases.
Specifically, this will allow for the addition of nodes that will
then be deactivated without negatively impacting the database for
other tests.