This repository has been archived by the owner on Aug 18, 2022. It is now read-only.
(MODULES-2244) Additional blacklist excludes #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Iristyle
commented
Oct 19, 2015
Iristyle
commented
- Remove WaitFor* resources
- Fix a bug that wasn't excluding all samples due to case-sensitivity
- Abort type generation if WaitFor* resources have been accidentally re-included
- Kill the rake building task completely if any WaitFor* resources are found.
- The WaitFor* resources are typically added manually by copying the schemas from a Windows machine with WMF5. Since these resources are not supported, manually delete them and regenerate the code generated types as well.
- A couple of straggler files were included based on our Rake tasks being case sensitive
|
This looks good. I'm not totally sold on the need for a rake abort if WaitFor* resources are found, but if a user trying to build their own custom items runs into that, I guess they will follow up with an issue. |
| @@ -110,6 +110,8 @@ eod | |||
| task :build, [:module_path] do |t, args| | |||
| module_path = args[:module_path] || default_dsc_module_path | |||
| m = Dsc::Manager.new | |||
| wait_for_resources = Dir["#{module_path}/**/*WaitFor*"] | |||
| fail "WaitFor* resources found - aborting type building!\n\n#{wait_for_resources}\n" if !wait_for_resources.empty? | |||
There was a problem hiding this comment.
This is interesting...
There was a problem hiding this comment.
Yeah, this is not an ideal way of doing this I agree.
It's mainly a guard against accidentally re-vendoring anything related to WaitFor. The hope would be that we can replace our current manual vendoring process with something automated in the future, and remove the need for this altogether.
ferventcoder
added a commit
that referenced
this pull request
Oct 19, 2015
…tional-blacklist (MODULES-2244) Additional blacklist excludes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.