Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

ability to insert local modules #16

Closed
AtzeDeVries opened this issue Dec 27, 2016 · 6 comments
Closed

ability to insert local modules #16

AtzeDeVries opened this issue Dec 27, 2016 · 6 comments

Comments

@AtzeDeVries
Copy link

Hi,

If you develop a puppet module and in combination with this project you get a lot of overhead since you have to

  1. Push your code somewhwere (git / svn)
  2. Change Puppetfile in so that docker will think there is a change
  3. Wait until r10k has installed all modules

It would be easer to have a agurment for this (which can be used multipe times). Something like
puppet docker build --add-module /path/to/your/module and it will translate into the docker file like this
COPY /path/to/your/module /etc/puppetlabs/code/modules/modulename
where modulename is the last part of /path/to/your/module

this line en should be inserted before init.pp is applied.

@oc243
Copy link

oc243 commented Jan 14, 2017

+1 --modulepath would be even better, which could point to a directory containing the modules (as is the case with vanilla puppet apply) that are to be copied into the container.

@garethr
Copy link
Contributor

garethr commented Jan 15, 2017

@AtzeDeVries @oc243 thanks, good suggestion. I like the idea --modulepath too. If anyone has time and inclination to look at a PR please do, otherwise I'll look to add this when I get a moment. Cheers

garethr added a commit that referenced this issue Feb 12, 2017
@garethr
Copy link
Contributor

garethr commented Feb 12, 2017

@AtzeDeVries @oc243 I've a PR up with this functionality at #27

Because the tool is implemented as a puppet subcommand we can't reuse the modulepath option. The current PR therefore uses module_path which I'm unsure about being the right option. I'd love any feedback you might have, and if you get a chance to try out and see if it addresses your needs.

@oc243
Copy link

oc243 commented Feb 12, 2017

Thanks @garethr. I'll try this out in the morning.

garethr added a commit that referenced this issue Feb 12, 2017
@oc243
Copy link

oc243 commented Feb 13, 2017

Just tried this and it seems to work well. TY!

@garethr
Copy link
Contributor

garethr commented Feb 20, 2017

Closed via #27

@garethr garethr closed this as completed Feb 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants