This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Adding Apache Example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added apache example that will work for Ubuntu or RHEL (defaults
to Ubuntu). In order to use it with RHEL you do need to pass both
the `from` option as well as `cmd` ("/usr/sbin/httpd,-DFOREGROUND")
sheenaajay
approved these changes
Jan 19, 2017
sheenaajay
reviewed
Jan 19, 2017
| @@ -0,0 +1,15 @@ | |||
| class { '::apache': | |||
| default_vhost => false, | |||
There was a problem hiding this comment.
Modify from class { '::apache': to class { 'apache':
There was a problem hiding this comment.
@sheenaajay the format with :: is more correct. This avoids issues with finding classes at other parts of the hierarchy.
|
@ipcrm Thanks Matt for the contribution. Apologize for the delay.Please find the minor comments on the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added apache example that will work for Ubuntu or CentOS (defaults to Ubuntu). In order to use it with CentOS you do need to pass both the
from("centos:7") option as well ascmd("/usr/sbin/httpd,-DFOREGROUND")