This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
(QA-2355) add classifiers #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'License :: OSI Approved :: Apache Software License', | ||
| 'Programming Language :: Python :: 2', | ||
| 'Programming Language :: Python :: 2.7', | ||
| ] |
There was a problem hiding this comment.
Does not follow PEP8 block assignment formatting.
There was a problem hiding this comment.
I couldn't find what pep8 block assignment formatting is with a quick google, but the pep8 linter doesn't complain. Is that the hanging comma or the hanging bracket?
There was a problem hiding this comment.
The hanging bracket. We already established the formatting style in our other Python modules.
jpinsonault
force-pushed
the
qa-2355-add-classifiers
branch
from
adaffe7
to
4036368
Compare
|
Rebased and addressed comments |
Adds classifier meta-data to setup.py
jpinsonault
force-pushed
the
qa-2355-add-classifiers
branch
from
4036368
to
a5db4cf
Compare
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #4, it should be merged before this one. Only look at the last commit.
Adds classifier meta-data to setup.py