Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Make kubernetes containers a directory #203

Closed
MikaelSmith opened this issue Apr 11, 2019 · 0 comments · Fixed by #763
Closed

Make kubernetes containers a directory #203

MikaelSmith opened this issue Apr 11, 2019 · 0 comments · Fixed by #763
Assignees
@MikaelSmith
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MikaelSmith
Copy link
Contributor

MikaelSmith commented Apr 11, 2019 •
edited

Kubernetes containers should follow a similar format to docker containers:

log
metadata.json
fs/

If we can't access the log due to permissions issues, we can omit the log file.

The implementation should look similar to https://github.com/puppetlabs/wash/blob/master/plugin/docker/container.go, where we list 'log' and 'metadata' entries for the pod, implement metadata for the pod, and then add pod_metadata and pod_log implementations to implement the files using references back to the pod. Also use the volume helpers to expose the filesystem.
@MikaelSmith MikaelSmith added the enhancement New feature or request label Apr 11, 2019
@MikaelSmith MikaelSmith changed the title Make kubernetes pods a directory Make kubernetes pods a directory, support multiple containers Apr 25, 2019
@MikaelSmith MikaelSmith added the good first issue Good for newcomers label Apr 25, 2019
@MikaelSmith MikaelSmith changed the title Make kubernetes pods a directory, support multiple containers Make kubernetes pods a directory Apr 25, 2019
@MikaelSmith MikaelSmith mentioned this issue Apr 25, 2019
Closed
@MikaelSmith MikaelSmith changed the title Make kubernetes pods a directory Make kubernetes containers a directory May 23, 2019
@MikaelSmith MikaelSmith mentioned this issue Jun 13, 2019
Closed
@MikaelSmith MikaelSmith mentioned this issue Feb 25, 2020
Closed
@MikaelSmith MikaelSmith self-assigned this Mar 27, 2020
MikaelSmith added a commit to MikaelSmith/wash that referenced this issue Mar 30, 2020
@MikaelSmith
Fix possible bug when requesting tty with no input
d88bf42 
We now always specify the stdin parameter if we expect to pass a stdin
io.Writer. This causes tty=true invocations to hang and timeout, but we
never call it with a tty (until puppetlabs-toy-chest#203).

Signed-off-by: Michael Smith <michael.smith@puppet.com>
MikaelSmith added a commit to MikaelSmith/wash that referenced this issue Mar 30, 2020
@MikaelSmith
Make kubernetes containers a directory
837cd6d 
Change the Kubernetes container entry to a directory mirroring the
Docker container structure: log, metadata, filesystem.

Also fixes using a tty with the container's exec method (which was
previously unused).

Resolves puppetlabs-toy-chest#203.

Signed-off-by: Michael Smith <michael.smith@puppet.com>
@MikaelSmith MikaelSmith mentioned this issue Mar 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikaelSmith MikaelSmith

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make kubernetes containers a directory MikaelSmith/wash
1 participant
@MikaelSmith