This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Make ls long output more consistent with other ls implementations #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
New format displays: verbs, size, mtime, name ``` delete, read, write 223 17 Jun 20 20:32 UTC MAINT.md delete, read, write 5106 17 Jun 20 20:32 UTC README.md delete, read, write 18734 17 Jun 20 20:24 UTC wash-logo-lg.png delete, read, write 9264 17 Jun 20 20:24 UTC wash-logo.png ``` This is more consistent with other `ls` implementations, although it still leaves out owner/group because they're not relevant to most objects in Wash. Signed-off-by: Michael Smith <michael.smith@puppet.com>
MikaelSmith
commented
Jun 17, 2020
| verbs := strings.Join(entry.Actions, ", ") | ||
| row = []string{cname(entry), mtimeStr, verbs} | ||
| row = []string{verbs, sizeStr, mtimeStr, cname(entry)} |
There was a problem hiding this comment.
Noticed pad also needs to be updated.
MikaelSmith
added a commit
to MikaelSmith/wash
that referenced
this pull request
Jun 17, 2020
Ensures `ls -l` still works when listing files and multiple directories. Fixes issues introduced in puppetlabs-toy-chest#776. Signed-off-by: Michael Smith <michael.smith@puppet.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New format displays: verbs, size, mtime, name
This is more consistent with other
lsimplementations, although it still leaves out owner/group because they're not relevant to most objects in Wash.