This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Load all available k8s auth plugins instead of GCP only #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skymeyer
requested review from
a team and
ekinanp
and removed request for
a team
|
Hi! 💖 Thanks for your contribution 🎉🥳 We'll get it reviewed as soon as possible. If you'd like to chat with the developers, the #puppet-dev channel on Slack would probably be a great place to start. Make sure that your commit messages fit our contribution standards to make the code review go quickly. If this is your first contribution to our repositories, then we'd love to send you a small welcome gift 🎁. Drop us a line at community@puppet.com and let us know where to send it! (/cc @puppetlabs/community) |
|
|
Signed-off-by: skymeyer <jelle.vink@gmail.com>
MikaelSmith
approved these changes
Mar 2, 2021
|
Congrats on merging your first pull request in this repository! 🏅 |
|
I'll try to get a release of it out later today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
washwith kubernetes clusters a warning is returned:This PR loads all available auth plugins instead of the one for
gcponly (https://github.com/kubernetes/client-go/blob/master/plugin/pkg/client/auth/plugins.go), but will eat up some additional dependencies doing so.