(MAINT) Use puppet.com URLs instead of puppetlabs.com #78
Conversation
This is particularly important because apt.puppetlabs.com and yum.puppetlabs.com don't support IPv6 resolution.
|
@raphink Please prepend your commit message with either (Maint) or a Beaker Ticket to follow our contributing standards. Please also note that we are getting the following test failures: 04:46:32 Failures: |
|
@melissa Would you mind looking at these url changes? I just want to make sure they don't break any of our internal tests by changing them. |
|
There are a few other places where we reference puppetlabs.com in this repo. Would it be worth it to change these as well? |
|
This looks like it doesn't break internal testing from what I can tell, though I'm not sure how to test pm.puppet.com. cc/ @shrug does someone from RE have the bandwidth to take a look at this? |
|
@raphink we're getting ready to cut a beaker-puppet release soon. It would be good to include this change, but we don't want to wait too long. At the very least, we need to update these failing tests before we can merge this. |
|
Thanks @melissa. My issue turned out to be a DNS resolver that didn't accept TCP connections, so the current beaker actually works for me. That said, I'm guessing it might still be good to replace these URLs eventually. |
|
@raphink it looks like at least some of these test failures are related to your changes (from spec testing): 04:47:06 4) ClassMixedWithDSLInstallUtils#install_puppet_agent_pe_promoted_repo_on when setting different agent versions sets correct file paths for agent version > 5.99
04:47:06 Failure/Error: fetch_http_file( release_path, download_file, copy_dir_local)
04:47:06
04:47:06 #<ClassMixedWithDSLInstallUtils:0x00000001b29890> received :fetch_http_file with unexpected arguments
04:47:06 expected: (/pm\.puppetlabs\.com\/puppet-agent\/.*\/6.0\/repos/, /puppet-agent-el-6*/, /\/el$/)
04:47:06 got: ("http://pm.puppet.com/puppet-agent/3.0/6.0/repos", "puppet-agent-el-6-x4.tar.gz", "tmp/repo_configs/el")@melissa or @shrug, are there any sync issues between this PR & RE releases that we should be aware of for timing of the cut & release of the next beaker-puppet containing it? |
|
I don't believe there are any sync issues with this. The hosts should cleanly map between pupppetlabs.com and puppet.com, but it would be good to get confirmation from RE on that. |
|
No blocker from RE, this should be fine |
|
I am a little confused by the assertion that the {yum,apt,downloads}.puppetlabs.com addresses are not resolvable via ipv6, they should be, they are just CNAMEs: |
|
@raphink posted an update for days ago
So the puppetlabs.com addresses should be resolvable |
|
I can confirm yum.puppetlabs.com works over IPv6 since my IPv6-only server can use it just fine. I did have an issue for some time a while back, but that's been resolved by now. |
|
There are some spec testing failures here that are simply matching against the old puppetlabs URLs & should be updated with the new puppet.com ones. I've made a small commit for this since we originally made those tests & submitted it against this branch as https://github.com/raphink/beaker-puppet/pull/1. Once you take that into this branch and added either |
|
Merged on my side |
|
cool, now we just need the git commit message to have the right reference (either |
sbeaulie
changed the title
sbeaulie
changed the title
This is particularly important because apt.puppetlabs.com and
yum.puppetlabs.com don't support IPv6 resolution.