Don't merge name => all to inventoryfile before resolving reference
#2475
Assignees
Labels
Bug
Bug reports and fixes.
Comments
beechtom
added a commit
to beechtom/bolt
that referenced
this issue
Dec 18, 2020
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
beechtom
added a commit
to beechtom/bolt
that referenced
this issue
Dec 18, 2020
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
beechtom
added a commit
to beechtom/bolt
that referenced
this issue
Dec 18, 2020
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
beechtom
added a commit
to beechtom/bolt
that referenced
this issue
Dec 18, 2020
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
beechtom
added a commit
to beechtom/bolt
that referenced
this issue
Jan 4, 2021
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
beechtom
added a commit
to beechtom/bolt
that referenced
this issue
Jan 5, 2021
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
lucywyman
added a commit
that referenced
this issue
Jan 5, 2021
(GH-2475) Allow entire inventory to be a plugin reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
Bolt should support an inventoryfile that only contains a plugin reference:
Additional context
The inventory schema will also need to be updated to accept a plugin at the top level.
The text was updated successfully, but these errors were encountered: