(GH-2475) Allow entire inventory to be a plugin reference #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beechtom
force-pushed
the
2475/inventory-plugin
branch
from
f6f7af7
to
608c608
Compare
beechtom
force-pushed
the
2475/inventory-plugin
branch
from
608c608
to
b167dac
Compare
|
Ugh, needs a rebase :( Sorry I totally forgot about this! |
beechtom
force-pushed
the
2475/inventory-plugin
branch
from
b167dac
to
186569b
Compare
lucywyman
reviewed
Jan 5, 2021
This change allows an entire inventory to be a plugin reference. For exmaple, the following inventory was previously invalid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ``` A top-level plugin like this used to be invalid as Bolt automatically added `'name' => 'all'` to the top of the loaded inventory, which would cause a plugin to receive a `name` parameter and (likely) error. Now, Bolt will resolve a top-level plugin reference, validate that the resolved data does not include a `name` key, and then merge in `'name' => 'all'`. !bug * **Allow entire inventory to be specified with a plugin** ([puppetlabs#2475](puppetlabs#2475)) Inventory files can now be specified with a plugin. For example, the following inventory file is now valid: ```yaml --- _plugin: yaml filepath: /path/to/inventory_partial.yaml ```
beechtom
force-pushed
the
2475/inventory-plugin
branch
from
186569b
to
a528e02
Compare
lucywyman
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Awesome! Verified this works with a top-level plugin and nested plugins and doesn't use additional keys (like a top level targets key). Also verified the group name merging warns if a name is set from the plugin, and that any group named all raises the collision error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows an entire inventory to be a plugin reference. For
exmaple, the following inventory was previously invalid:
A top-level plugin like this used to be invalid as Bolt automatically
added
'name' => 'all'to the top of the loaded inventory, which wouldcause a plugin to receive a
nameparameter and (likely) error. Now,Bolt will resolve a top-level plugin reference, validate that the
resolved data does not include a
namekey, and then merge in'name' => 'all'.!bug
Allow entire inventory to be specified with a plugin
(#2475)
Inventory files can now be specified with a plugin. For example, the
following inventory file is now valid: