Run 'plan convert' with plan name #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beechtom
force-pushed
the
hack/plan-convert
branch
from
8faf25d
to
89278e9
Compare
lucywyman
reviewed
Mar 15, 2021
lucywyman
reviewed
Mar 15, 2021
This adds support for calling `bolt plan convert` and `Convert-BoltPlan` with the name of a plan instead of just the path to a plan. !feature * **Convert YAML plans by name** The `bolt plan convert` and `Convert-BoltPlan` commands now accept the name of a YAML plan to convert instead of just a path to a YAML plan.
beechtom
force-pushed
the
hack/plan-convert
branch
from
89278e9
to
929e0e4
Compare
lucywyman
reviewed
Mar 15, 2021
| # If the plan was loaded, look for it on the module loader | ||
| # There has to be an easier way to do this... | ||
| if sig | ||
| type = compiler.list_plans.find { |p| p.name == plan } |
There was a problem hiding this comment.
Hmm I spent some time looking to see if there's a better way, but I think that might have diminishing returns - ultimately I don't think it's going to be a whole lot more efficient or readable than this :/
There was a problem hiding this comment.
I think you can do something like
typed_name = Puppet::Pops::Parser::TypedName.new(:plan, plan)
Puppet.lookup(:loaders).private_environment_loader.find(typed_name)
lucywyman
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for calling
bolt plan convertandConvert-BoltPlanwith the name of a plan instead of just the path to a plan.
!feature
Convert YAML plans by name
The
bolt plan convertandConvert-BoltPlancommands now accept thename of a YAML plan to convert instead of just a path to a YAML plan.