Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r10k: Require 4.x & octokit: Allow newer versions & puppetlabs_spec_helper: Require 7.x #3249

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bastelfreak
Copy link
Contributor

This is a requirement to get newer dependencies for modules testing. pdk configures puppet_litmus, which in turn depends on bolt, which depends on outdated other gems.

@bastelfreak bastelfreak requested a review from a team as a code owner November 27, 2023 12:40
@@ -60,15 +60,15 @@ Gem::Specification.new do |spec|
spec.add_dependency "puppetfile-resolver", ">= 0.6.2", "< 1.0"
spec.add_dependency "puppet-resource_api", ">= 1.8.1"
spec.add_dependency "puppet-strings", ">= 2.3.0", "< 5.0"
spec.add_dependency "r10k", "~> 3.10"
spec.add_dependency "r10k", "~> 4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cant drop support for 3. We can update to support both 3 and 4 if that is helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I took a bit of a break in responding here because the whole Ruby situation in the Puppet/Perforce tooling is a bit frustrating.

In theory we could do spec.add_dependency "r10k", ">= 3.10", "< 5". But bundler showed in the past that it had some trouble to figure out correct versions / it didn't always hounor the minimal ruby version in the dependencies. I don't know if this keeps working on ruby 2.5 / 2.6 if we do the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec.add_dependency "r10k", ">= 3.10", "< 5" seems reasonable to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in order to actuallly use the new r10k version, we need a release of puppetlabs/orchestrator_client-ruby#38 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

bolt.gemspec Outdated Show resolved Hide resolved
@bastelfreak
Copy link
Contributor Author

@donoghuc why does bolt need to support Ruby 2.5? Why cant we drop it?

bastelfreak added a commit to bastelfreak/bolt that referenced this pull request May 9, 2024
This updates all version constraints for development
dependencies in gemspec to allow their latest major versions.

Followup for puppetlabs#3249
@donoghuc
Copy link
Member

I think we can drop 2.5 for bolt 4.

@bastelfreak
Copy link
Contributor Author

For bolt 4? Why can't we drop it now? Or do you mean for Bolt 3?

@donoghuc
Copy link
Member

The only reason we've kept 2.5 is for some internal testing on older OS. I was thinking of updating all that when we move to making the default ruby 3 based (keeping ruby 2.7 compatability for 2021.7 PE stream). What is the min version being 2.5 preventing for you now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants