Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update for Puppet 7 compability #86

Merged
merged 3 commits into from
May 23, 2022
Merged

Conversation

tkishel
Copy link
Contributor

@tkishel tkishel commented Dec 14, 2021

Puppet 7 removes lib/puppet/ssl/host.rb and the Puppet::SSL::Host class.
The Puppet.valid_digest_algorithms method works just fine.
This addresses Issue #85

@tkishel tkishel requested a review from a team as a code owner December 14, 2021 23:06
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2021

CLA assistant check
All committers have signed the CLA.

@binford2k
Copy link

Hi friend!

binford2k
binford2k previously approved these changes Dec 15, 2021
@tkishel
Copy link
Contributor Author

tkishel commented Dec 15, 2021

Hello Friend!

This was in response to a post in the puppet Slack channel.
It should close Issue 85 (once someone builds and uploads this module to the Forge!)

metadata.json Outdated Show resolved Hide resolved
metadata.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 9, 2022

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label May 9, 2022
@bastelfreak
Copy link
Collaborator

Hi Puppet :)
What's the point of a stale bot that closes PRs where the community waits for reviews from your side ;) Any Chance this can be merged in the near future?

@chelnak
Copy link
Contributor

chelnak commented May 9, 2022

Hey @bastelfreak,

With community day starting again soon, I'm hoping we will get less of these instances.

I've removed the label so this PR is active again.

@chelnak chelnak removed the stale label May 9, 2022
@bastelfreak
Copy link
Collaborator

community day is coming back? nice \o/

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was a little worried about the support changes being in the same PR, but can work around that for the release

@david22swan david22swan merged commit bc454ec into puppetlabs:main May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants