Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

(FACT-2492) handle elementary OS as Debian #408

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

mihaibuzgau
Copy link
Contributor

No description provided.

@mihaibuzgau mihaibuzgau requested review from a team March 25, 2020 13:03
BogdanIrimie
BogdanIrimie previously approved these changes Mar 25, 2020
Comment on lines +55 to +56
when :elementary
%w[Debian]
Copy link
Contributor

@gimmyxd gimmyxd Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: are we going to do this for each distro that is based on other distros?
I think there are a lot of them that are based on ubuntu/debian, maybe we can identify them better.

https://en.wikipedia.org/wiki/Category:Debian-based_distributions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, working on a POC for this. Right now it would be great if we could unstuck facter for Elementary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did the old versions of facter do this mapping?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Facter 3 is using CMAKE variable CMAKE_SYSTEM_NAME (which is the result of uname -s) to differentiate at build time on which os is running. Elementary and Debian will be just 'Linux' in this case. Facter 2 is using Facter::Core::Execution.exec("uname -s").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, working on a POC for this. Right now it would be great if we could unstuck facter for Elementary.

@mihaibuzgau Any ETA on this? I need to get facter working on Raspbian and could extend this yet again, but if you have a PR coming I could wait a bit for something cleaner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlove-au for the moment, please add Raspbian similar to ElementaryOS, the effort is low and you will be able to use Facter 4 with Raspbian. We are already working on the new mechanism, but it might take some time until we implement, test and release it.

@BogdanIrimie BogdanIrimie merged commit 106aebd into puppetlabs:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants