Address Feature #5193 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
John - looks like you based this off master? The current HEAD is next. Can you rebase and update for that? Thanks! |
|
Sure thing. Ill get a new pull in here shortly |
|
Okay. New pull request out there. Added some comments. There's a weird bug on mri 1.8.7. Might be related to my local RVM install though. |
adrienthebo
pushed a commit
that referenced
this pull request
Aug 7, 2013
Cumulus Linux RSpec additions
kylog
pushed a commit
that referenced
this pull request
Jun 10, 2014
(FACT-480) Remove current directory from Ruby load path.
smortex
pushed a commit
to smortex/facter
that referenced
this pull request
Nov 25, 2022
…odule (BOLT-533) Externalize module
smortex
pushed a commit
to smortex/facter
that referenced
this pull request
Nov 25, 2022
…gain Minor changes to quoting and builtins
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic JSON support for facter output. Since JSON doesn't ship with the VM by default, it's wrapped in a LoadError rescue in cases where JSON isn't isntalled.