(FACT-1277) Add puppetversion to facter -p
#1221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `facter -p` was restored to Facter 3, the `puppetversion` fact was overlooked. It was moved to Puppet, but the code path we call to initialize `facter -p` doesn't set it up. Explicitly set it by calling `Puppet.version`, with support for a Puppet helper to be setup in PUP-5508 to future-proof `facter -p` for new core Puppet facts.
|
I updated facter's protected branches configs to point to the new appveyor status endpoint. |
|
Should we point this one at stable? |
|
Oops, I'll fix tomorrow. |
|
Retargeted stable as #1222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
facter -pwas restored to Facter 3, thepuppetversionfact wasoverlooked. It was moved to Puppet, but the code path we call to
initialize
facter -pdoesn't set it up. Explicitly set it by callingPuppet.version, with support for a Puppet helper to be setup inPUP-5508 to future-proof
facter -pfor new core Puppet facts.