Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-1277) Add puppetversion to facter -p #1222

Merged
merged 1 commit into from
Nov 19, 2015

Conversation

MikaelSmith
Copy link

When facter -p was restored to Facter 3, the puppetversion fact was
overlooked. It was moved to Puppet, but the code path we call to
initialize facter -p doesn't set it up. Explicitly set it by calling
Puppet.version, with support for a Puppet helper to be setup in
PUP-5508 to future-proof facter -p for new core Puppet facts.

When `facter -p` was restored to Facter 3, the `puppetversion` fact was
overlooked. It was moved to Puppet, but the code path we call to
initialize `facter -p` doesn't set it up. Explicitly set it by calling
`Puppet.version`, with support for a Puppet helper to be setup in
PUP-5508 to future-proof `facter -p` for new core Puppet facts.
@peterhuene
Copy link

👍

kylog pushed a commit that referenced this pull request Nov 19, 2015
(FACT-1277) Add puppetversion to `facter -p`
@kylog kylog merged commit e8493b7 into puppetlabs:stable Nov 19, 2015
@MikaelSmith MikaelSmith deleted the FACT-1277 branch December 16, 2015 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants