-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Add execute permissions on Windows test fixture #1248
Conversation
ping @melissa |
@MikaelSmith thanks! This doesn't impact anything else, right? Github permissions aren't respected on windows (as opposed to cygwin), right? |
Windows doesn't really care for the most part. |
cool, that's what I thought. 👍 |
@melissa if the perms are good, this is good. 👍 |
I'm getting a build error when building facter from this branch... it's probably because I'm trying to build from master everything else, but I'm verifying that now |
On Windows running inside Cygwin, the test using error_message.bat fails due to lack of execute permissions. Add the execute bit on batch files so tests will run successfully within Cygwin.
👍 and facter tests are passing as well! Thank you Michael! |
Go ahead and merge then. |
(maint) Add execute permissions on Windows test fixture
Thanks all! |
On Windows running inside Cygwin, the test using error_message.bat fails
due to lack of execute permissions. Add the execute bit on the file so
tests will run successfully within Cygwin.