(maint) Add execute permissions on Windows test fixture #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @melissa |
|
@MikaelSmith thanks! This doesn't impact anything else, right? Github permissions aren't respected on windows (as opposed to cygwin), right? |
|
Windows doesn't really care for the most part. |
|
cool, that's what I thought. 👍 |
|
@melissa if the perms are good, this is good. 👍 |
|
I'm getting a build error when building facter from this branch... it's probably because I'm trying to build from master everything else, but I'm verifying that now |
On Windows running inside Cygwin, the test using error_message.bat fails due to lack of execute permissions. Add the execute bit on batch files so tests will run successfully within Cygwin.
|
👍 and facter tests are passing as well! Thank you Michael! |
|
Go ahead and merge then. |
ferventcoder
added a commit
that referenced
this pull request
Jan 11, 2016
(maint) Add execute permissions on Windows test fixture
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows running inside Cygwin, the test using error_message.bat fails
due to lack of execute permissions. Add the execute bit on the file so
tests will run successfully within Cygwin.