(FACT-1281) Simplify acceptance tests #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `rake ci:test:packages` was the default rake target, but was unusable, because we don't build non-AIO packages anymore. This commit removes support for that rake task and changes the default to `aio`.
Previously, the presuite for AIO called `install_repos_on` for all host platforms, which was implemented in facter's install_utils helper. For redhat and debian platforms the method installed the corresponding repo_config. For other platforms, e.g. Windows, OSX, it installed puppet-agent using `install_puppet_agent_dev_repo_on`. For redhat and debian platforms, the presuite then called Beaker's `install_packages_on` method to execute `yum install puppet-agent`, etc. This commit modifies the presuite to install puppet-agent using Beaker's `install_puppet_agent_dev_repo_on` on all platforms. On rpm/deb platforms, it installs the repo_config and uses the package manager to install puppet-agent, e.g. `yum install -y puppet-agent`. The previous commit removed `packages` style acceptance testing, and `aio` no longer calls `install_repos_on`, so this commit removes it along with related helper code. This commit bumps our Beaker dependency to use the latest `install_puppet_agent_dev_repo` method.
|
verified using: |
|
@er0ck @johnduarte @MikaelSmith similar changes to facter |
| @@ -10,7 +10,7 @@ def location_for(place, fake_version = nil) | |||
| end | |||
| end | |||
|
|
|||
| gem "beaker", *location_for(ENV['BEAKER_VERSION'] || "~> 2.27") | |||
| gem "beaker", *location_for(ENV['BEAKER_VERSION'] || "~> 2.32") | |||
There was a problem hiding this comment.
are you trying to prevent this from updating Y version?
There was a problem hiding this comment.
Wanting to ensure we install at least 2.32.0 (but less than 3.0) since 2.32 is the first version that contains the correct install_puppet_agent_dev_repo_on implementation.
|
LGTM 👍 |
|
👍 |
er0ck
added a commit
that referenced
this pull request
Jan 13, 2016
…lify-acceptance-tests (FACT-1281) Simplify acceptance tests
|
Passed on AIX 6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for
packagestype of acceptance, bumps our beaker dependency, and uses beaker's updatedinstall_puppet_agent_dev_repo_onmethod to install puppet-agent on all platforms.