(PA-139) unify pa acceptance workflows #4539
Conversation
er0ck
changed the title
This change fixes developer helper tasks made for managing acceptance VMs easier. We also remove methods that are superseded by beaker functionality. [skip ci]
Fix the releasing of hosts helper task by using the user's vmpooler token from their .fog file. We also remove some lingering preserved_config logic, which is no longer used due to improvements in beaker. [skip ci]
Many people run with beaker standalone. Common and required options have been moved to the options files to support this workflow in this change. We also move common options to their own file and load them into the other options files that are loaded by beaker. [skip ci]
er0ck
force-pushed
the
acceptance/stable/maint-unify_PA_acceptance_workflows
branch
from
bd7d385
to
452a304
Compare
er0ck
changed the title
er0ck
changed the title
This change moves host file generation to its own task. This separates its concerns from the testing tasks, and allows the testing tasks to be dependent upon it. [skip ci]
er0ck
changed the title
|
i only tested the test_against_preserved_hosts task with an empty simple test. further testing reveals that beaker wipes out the HOSTS hash when using any options file that points at a preserved_hosts file. i believe a work around is available that i'm working out for deployer. digging into the morass of coupling that is the beaker options parser is probably not the best route for now... |
|
suggestion to use |
|
yeah, i'm sold on BEAKER_HOSTCONFIG use. i have a couple other updates for this PR. but maybe we should just get those minimal changes in, similar to your hiera PR and then i'll rebase this one as it has extensive unrelated changes. |
|
floating an update to |
| :preserve_hosts => 'onfail', | ||
| :forge_host => 'forge-aio01-petest.puppetlabs.com', | ||
| :'master-start-curl-retries' => 30 | ||
| } |
There was a problem hiding this comment.
review note: moved most of these to the config files so one can run more easily from beaker standalone without repeated code.
|
Is this starting from a baseline that's compatible with the changes in FACT-1281? |
|
@MikaelSmith not yet. but it can be. we should probably wait until after the release for stuff like this PR |
|
wrong branch name. re-opening |
(PA-139) acceptance: allow multiple options to beaker using OPTIONS
(PA-139) acceptance: move beaker host generation to own task
(PA-139) add tmp hostgenerator dir to rake clean list
(PA-139) move common options out of Rakefile
(PA-139) acceptance: fix running against preserved_hosts
(PA-139) fix releasing of preserved hosts
(PA-139) fix listing of preserved hosts
(PA-139) acceptance: Rakefile: deprecate CONFIG in favor of HOSTS
(PA-139) acceptance: remove passenger and packages installs
[skip ci]