Feature/facter 2/fact 65 add default aggregate, freeze chunks #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Facter::Util::Resolution class contained behavior for determining if a resolution was suitable, the precedence of the resolution, code for safely resolving values, and code for actually resolving information. This commit breaks up the Resolution class into a Suitable mixin for determining if a resolution can run and the precedence of that resolution, and a Resolvable mixin for handling behavior around the resolution of a given fact.
Before this commit, errors occurred while evaluating an aggregate resolution would be rescued and logged, which could mask problems and cause more failures later. This commit removes the error handling so that evaluations fail early.
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines the behavior of aggregate resolutions in two ways.
The first change is that chunk values will be frozen after they are evaluated. This means that when one chunk inspects another chunk, it cannot accidentally modify the already evaluated data.
The second change adds a default aggregate action for aggregate resolutions. The default aggregate action assumes that all resolved chunks will be data structures that can be deeply merged, so that people don't need to redefine this behavior every time.
This pull request is based on GH-605 and should be merged after that.