Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redhat 7, 8, 9 images #72

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Feb 12, 2024

Is there a reason these haven't been added yet?

https://developers.redhat.com/articles/ubi-faq#

UBI base image is the new de facto container base image for Red Hat Enterprise Linux 8, and it is available on Red Hat Enterprise Linux 7 as an optional and alternative to the pre-UBI image. The UBI base image is freely redistributable under the UBI EULA.

puppetlabs/provision#255 PR required to fix docker ssh provision with puppet litmus testing.

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner February 12, 2024 15:17
@h0tw1r3 h0tw1r3 marked this pull request as draft February 12, 2024 16:21
@jordanbreen28 jordanbreen28 changed the title add support for redhat 7, 8, 9 images add redhat 7, 8, 9 images Feb 12, 2024
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Feb 12, 2024

drafted because systemd not coming up in container with current dockerfile (needs udev). working on it.

@h0tw1r3 h0tw1r3 force-pushed the redhat-ubi branch 8 times, most recently from 1765529 to 19cfbb6 Compare February 14, 2024 15:27
github.event.* contains information from the calling
workflow. to access the current context (called workflow)
inputs, always use inputs (not github.event.inputs).
@h0tw1r3 h0tw1r3 marked this pull request as ready for review February 14, 2024 15:34
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Feb 14, 2024

Includes fix for #74 when called from the CI workflow.

According to the documentation: "When a workflow is triggered with the workflow_call event, the event payload in the called workflow is the same event payload from the calling workflow." In other words, the event parameter in the github context is the same for the called workflow as for the original workflow.

Consequently, when the template is used from the CI workflow, there are no github.event.input.* parameters since the original workflow did not have this input. 😢

@jordanbreen28 jordanbreen28 merged commit 4fbec06 into puppetlabs:main Feb 14, 2024
6 checks passed
@h0tw1r3 h0tw1r3 deleted the redhat-ubi branch February 14, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants