Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Adding banners support #40

Merged
merged 1 commit into from Aug 6, 2018
Merged

(Feature) Adding banners support #40

merged 1 commit into from Aug 6, 2018

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Jul 31, 2018

No description provided.

@tphoney tphoney requested a review from shermdog July 31, 2018 14:29
@tphoney
Copy link
Contributor Author

tphoney commented Jul 31, 2018

changed the name to banners, this is controversial !

@tphoney tphoney force-pushed the banner branch 3 times, most recently from 4a5ec57 to fef4087 Compare July 31, 2018 15:31
@shermdog
Copy link
Contributor

I don't see a benefit to changing the name to banners. On the ios/nxos/eos command line they are banner x. We've also already released the type as banner with cisco_ios

@tphoney
Copy link
Contributor Author

tphoney commented Aug 1, 2018

changed

@tphoney tphoney mentioned this pull request Aug 2, 2018
Merged
@shermdog shermdog mentioned this pull request Aug 3, 2018
Merged
@shermdog shermdog merged commit 01532cf into puppetlabs:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shermdog shermdog Awaiting requested review from shermdog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tphoney @shermdog