(CISCO-71) Add support for banner/motd

[shermdog]

This will provide support for new netdev_stdlib banner/motd type.
puppetlabs/netdev_stdlib#40

[mikewiebe]

@shermdog Are you done with this PR and ready for me to review?

[shermdog]

@mikewiebe I think it's close now. I'm going to get some beaker tests together for the puppet module and put a PR up for that so it can all be done in one fell swoop.

[shermdog]

@mikewiebe this should be good to merge. Added PR for puppet module.

[mikewiebe]

This test fails on my devices.

Node under test:
  - name    - n9k
  - type    - N9K-C9504
  - image   - bootflash:///nxos.9.2.1.bin
  - version - 9.2(1)

TestBanner#test_motd = 3.62 s = F

Finished in 3.625701s, 0.2758 runs/s, 1.1032 assertions/s.

  1) Failure:
TestBanner#test_motd [tests/test_banner.rb:49]:
Expected "User Access Verification\n" to be nil.

1 runs, 4 assertions, 1 failures, 0 errors, 0 skips

The behavior on my devcies is as follows.

n9k# conf t
Enter configuration commands, one per line. End with CNTL/Z.
n9k(config)# no banner motd
n9k(config)# 
n9k(config)# end
n9k# 
n9k# show banner motd 
User Access Verification
n9k# 

I see that you are setting the default to this but asserting for nil?

Should this be using refute_nil instead?

[mikewiebe]

Or.. why not check that it is set to the default value?

[shermdog]

Good catch - missed updating this when I changed the behavior :)

[mikewiebe]

It would be nice to have a multiline banner check test for versions >= 7.0(3)I7(4)

[shermdog]

Do you have any examples handy on fencing this for that release? Don't want to run up against unuspported platforms/versions.

[mikewiebe]

We can use the step_unless_legacy_defect() method.

Here is an example:

cisco-network-node-utils/tests/test_tacacs_global.rb

Line 80 in 3b254e7

skip_versions = ['7.0.3.(I2|I3)', '7.0.3.I4.[1-7]']

Versions that we support and need to skip would be

skip_versions = ['7.0.3.I[2-6]', '7.0.3.I7.[1-3]', '7.3', '8.[1-3]']

The fix for the n7k will likely go into 8.4

[mikewiebe]

Don't worry about listing a defect number for now. Just add a message indicating that multiline banners are not supported.

[mikewiebe]

Alternatively we could extend

cisco-network-node-utils/tests/ciscotest.rb

Line 225 in 88e0d96

def skip_legacy_defect?(pattern, msg)

to skip a list of versions since the intent of step_unless_legacy_defect() is to skip a specific step within a test case.

[shermdog]

@mikewiebe fixed the broken test, extended skip_legacy_defect to skip array of versions and added multiline banner test.

Tested against: 7.0(3)I7(1), 7.0(3)I7(4), 9.2(1)

[mikewiebe]

Please update the message to be something along the lines of: multiline banner configuration using nxapi not supported

[mikewiebe]

@shermdog One minor comment and then should be good to merge