Add @apple_old_libdir variable for cleaning up old install data

[ccaviness]

To fix http://projects.puppetlabs.com/issues/22005

[puppetcla]

CLA signed by all contributors.

[MosesMendoza]

Note: This is related to puppetlabs/facter#512 and puppetlabs/puppet#1830

[djmitche]

Will this change the install location to simply /Library/Ruby/Site (the target of the /usr/lib/ruby/site-ruby symlink)? If so, that's awesome, because it obviates the need to install to different locations for different ruby versions, which would make installing things on OS X 10.9 much easier - see #176 for my approach. Maybe a hybrid of the two?

[ccaviness]

@djmitche Yeah, this will install in /Library/Ruby/Site directly, which will make it available and usable on all versions of OS X, whether they ship with 1.8 or 2.0.

[djmitche]

So I'm not sure why it uses a symlink, then? Why not just use /Library/Ruby/Site, or even better, get the path from RbConfig?

[ccaviness]

@djmitche Not certain; I think that's a decision out of scope of this pull request (that's how it was when I found it..), though I could easily add to it.

[djmitche]

Hm, good point. I'd like to get this in ASAP so that everything's ready for 10.9 when it's released, so minimal change is probably good. Given that, +1 :)

[MosesMendoza]

@ccaviness this looks good to me. Tested it too. Since we'll need to merge the changes across all the projects at roughly the same time, I'm going to coordinate with @adrienthebo to make sure everything is good to go with the puppet PRs. Hiera will also need changes similar to puppet and facter, I can port your work over there along with @djmitche's.

[MosesMendoza]

@ccaviness it looks like a merge commit snuck into your PR. Could you rebase against origin/master?

[MosesMendoza]

Related to puppetlabs/hiera#144

[ccaviness]

@MosesMendoza I'm unsure how to do that. Last time I tried something involving rebase I ended up with puppetlabs/puppet#1796

[MosesMendoza]

@ccaviness fair enough:) I can pull this in and merge manually. I'm waiting on #176 to be ready and then it can all be merged at once.

[ccaviness]

Yeah, see what happens when I try to do anything clever with git? I'll leave this to you :-/

[ccaviness]

Ok, I think I sorted it out. Does this look correct?

[adrienthebo]

@MosesMendoza do we want to handle these merges today?

[MosesMendoza]

@adrienthebo yes, I'm working with @haus on a strategy that varies slightly than what is in some of the open PRs. some new PRs to come.