(fix) Set rubocop ruby version to 2.4 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.1 has some changes to hash syntax. using 2.1 shows false positives
|
rubcop complained about wrong ruby version, only up to 2.4 is accepted. are there already any deadlines for dropping puppet 4 / ruby 2.1 support? |
tuxmea
changed the title
Fixed.
Support Puppet 4? Are you sure? |
|
puppetlabs/pdk-vanagon#268 is currently in progress to remove puppet4 and ruby 2.1 from pdk. That'll unblock this work. |
DavidS
approved these changes
Nov 27, 2020
|
the pdk change got merged, so this is unblocked. Since I'm away next week, I'll leave it to the team to merge on Community Monday. |
sanfrancrisko
changed the title
sanfrancrisko
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1 has some changes to hash syntax.
using 2.1 shows false positives