Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object templates for functions #379

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

logicminds
Copy link
Contributor

Previously pdk was not able to generate functions. This adds the templates to do so. This will need to merged before I can submit the PR in pdk to support functions.

Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo, other than that LGTM. By chance, do you happen to have the PDK PR ready that this is associated with?

object_templates/functions/function_spec.erb Outdated Show resolved Hide resolved
@sanfrancrisko sanfrancrisko self-assigned this Jan 11, 2021
@logicminds
Copy link
Contributor Author

@sanfrancrisko regarding the other PR. It is linked here: puppetlabs/pdk#932

It is complete and waiting to be merged.

@DavidS DavidS dismissed sanfrancrisko’s stale review January 18, 2021 10:56

requested changes applied

@DavidS DavidS merged commit 08da147 into puppetlabs:main Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants