Fix Logger.error
#173
Merged
Fix Logger.error
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, there was a `self.crit` method in `logger.rb` (calling `logger.error`), but no `self.error`. There was only one instance of `Logger.crit` in the code, but three instances of `Logger.error` that would all explode with ``` NoMethodError: undefined method `error' for PdkSync::Logger:Class ``` Fixes puppetlabs#172
Codecov ReportBase: 45.63% // Head: 45.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 45.63% 45.63%
=======================================
Files 10 10
Lines 1227 1227
=======================================
Hits 560 560
Misses 667 667
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chelnak
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, there was a
self.critmethod inlogger.rb(callinglogger.error), but noself.error.There was only one instance of
Logger.critin the code, but three instances ofLogger.errorthat would all explode withFixes #172