(#22128) Yum prefetch spec ensures use of yum provider #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefetch spec for the Yum package provider was failing on platforms whose default providers did not have the same capabilities (definitely on Windows for msi), because the previous implementation was generating type instances of Puppet::Type::Package without setting their providers. Consequently these instances were being generated with references to the platform's default providers, and might fail to set :ensure => :latest due to missing capabilities. The spec is changed to associate instances of yum providers with the package type instances being passed into prefetch. Also removed the confine for Windows. This also clears up a typo that got through in the original patch, which was failing on only some platforms.
|
CLA signed by all contributors. |
zaphod42
added a commit
that referenced
this pull request
Aug 13, 2013
…h-failure-solaris-spec-fix (#22128) Yum prefetch spec ensures use of yum provider
jpartlow
deleted the
issue/master/22128-yum-prefetch-failure-solaris-spec-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefetch spec for the Yum package provider was failing on platforms
whose default providers did not have the same capabilities (definitely
on Windows for msi), because the previous implementation was generating type
instances of Puppet::Type::Package without setting their providers.
Consequently these instances were being generated with references to the
platform's default providers, and might fail to set :ensure =>
:latest due to missing capabilities.
The spec is changed to associate instances of yum providers with the
package type instances being passed into prefetch. Also removed the
confine for Windows.
This also clears up a typo that got through in the original patch, which
was failing on only some platforms.