(PUP-1211) Force registry value encoding to match code page #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is PUP-1211 actually. |
|
@kylog good catch, updated commit message |
Ruby uses ANSI versions of Win32 APIs to read values from the registry. The encoding of these strings depends on the active code page. However, ruby incorrectly sets the string encoding to US-ASCII.[1] As a result, if you try to perform a regex match on the string, and the string contains the registered trademark symbol, 0xAE, then ruby will raise an error saying 'Invalid byte sequence in US-ASCII' This commit forces the encoding of REG_SZ, REG_EXPAND_SZ, and REG_MULTI_SZ to the encoding for the active code page. So if the active code page is 1252, the ruby encoding will be `Encoding::CP1252`. See https://bugs.ruby-lang.org/issues/8943
|
Travis failed on 4582499, because |
kylog
pushed a commit
that referenced
this pull request
Jan 8, 2014
…ry-encoding (PUP-1211) Force registry value encoding to match code page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby uses ANSI versions of Win32 APIs to read values from the registry. The
encoding of these strings depends on the active code page. However, ruby
incorrectly sets the string encoding to US-ASCII.[1]
As a result, if you try to perform a regex match on the string, and the string
contains the registered trademark symbol ®, then ruby will raise an error
saying 'Invalid byte sequence in US-ASCII'
This commit forces the encoding of
REG_SZ,REG_EXPAND_SZ, andREG_MULTI_SZtothe encoding for the active code page. So if the active code page is 1252, the
ruby encoding will be
Encoding::CP1252.See https://bugs.ruby-lang.org/issues/8943