(PUP-1885) Stringify ignores for file serving #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6353ebb introduced non-yaml encoding for arrays of HTTP parameters. Unfortunately this also exposed those values to the type conversion that is done to parameters in the HTTP layer, which caused an ignore for a file matching "0" to be turned into the number 0. The file serving code didn't handle getting non-string ignore patterns and would then raise an error. This changes the file server to stringify all of the parameters that it recieves for ignores, which solves both the number problem as well as a related one for booleans. An alternative solution to this would have been to change the HTTP handler so that it didn't try to convert arrays of values. I didn't go for that because it would have caused the parameter handling to be inconsistent.
This duplication actually bit me when writing the test for PUP-1885.
|
CLA signed by all contributors. |
kylog
pushed a commit
that referenced
this pull request
Mar 8, 2014
…ith-non-string-ignores (PUP-1885) Stringify ignores for file serving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6353ebb introduced non-yaml
encoding for arrays of HTTP parameters. Unfortunately this also exposed
those values to the type conversion that is done to parameters in the HTTP
layer, which caused an ignore for a file matching "0" to be turned into
the number 0. The file serving code didn't handle getting non-string
ignore patterns and would then raise an error.
This changes the file server to stringify all of the parameters that it
recieves for ignores, which solves both the number problem as well as a
related one for booleans.
An alternative solution to this would have been to change the HTTP handler
so that it didn't try to convert arrays of values. I didn't go for that
because it would have caused the parameter handling to be inconsistent.